New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retry on 'unexpected EOF' error #92005
Conversation
Hi @tkashem. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @sttts |
/assign @caesarxuchao |
The change looks fine. Is there a unit test for this? |
/ok-to-test |
/ok-to-test |
/retest |
'unexpected EOF' is usually a transient error. client-go request uses IsProbableEOF to determine whether it is going to retry a failed request.
/retest |
2 similar comments
/retest |
/retest |
@caesarxuchao I added unit tests for |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
unexpected EOF
is usually a transient error. client-go request usesIsProbableEOF
function to determine whether it is going to retry a failed request.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE